Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| f76534b632 |
@@ -1,4 +0,0 @@
|
|||||||
## 2025-06-03 - Avoid TextEncoder for string byte length
|
|
||||||
|
|
||||||
**Learning:** `new TextEncoder().encode(text).byteLength` allocates a `Uint8Array` for the entire string, which causes significant memory allocations and is ~100x slower for large JSON payloads in Bun/Node.
|
|
||||||
**Action:** Use `Buffer.byteLength(text)` when available (with a fallback to `TextEncoder` for browser compatibility) to compute string byte lengths without memory allocation overhead.
|
|
||||||
+5
-3
@@ -307,6 +307,10 @@ function PrivateApp() {
|
|||||||
[],
|
[],
|
||||||
);
|
);
|
||||||
|
|
||||||
|
const handleExcalidrawAPI = useCallback((api: ExcalidrawImperativeAPI) => {
|
||||||
|
excalidrawApiRef.current = api;
|
||||||
|
}, []);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="app-shell" ref={appShellRef}>
|
<div className="app-shell" ref={appShellRef}>
|
||||||
{toastMessage && (
|
{toastMessage && (
|
||||||
@@ -332,9 +336,7 @@ function PrivateApp() {
|
|||||||
onSceneChange={handleSceneChange}
|
onSceneChange={handleSceneChange}
|
||||||
onSelectionStateChange={handleCodeBlockSelectionChange}
|
onSelectionStateChange={handleCodeBlockSelectionChange}
|
||||||
onEditorActivity={scheduleThemeTokenSync}
|
onEditorActivity={scheduleThemeTokenSync}
|
||||||
onExcalidrawAPI={(api) => {
|
onExcalidrawAPI={handleExcalidrawAPI}
|
||||||
excalidrawApiRef.current = api;
|
|
||||||
}}
|
|
||||||
renderEmbeddable={renderCodeBlockEmbeddable}
|
renderEmbeddable={renderCodeBlockEmbeddable}
|
||||||
/>
|
/>
|
||||||
<CodeBlockSidebar
|
<CodeBlockSidebar
|
||||||
|
|||||||
@@ -30,20 +30,24 @@ function CodeBlockEditor({
|
|||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
let cancelled = false;
|
let cancelled = false;
|
||||||
void renderHighlightedCodeBlockHtml(draft.code, draft.language)
|
|
||||||
.then((nextHtml) => {
|
const timeoutId = setTimeout(() => {
|
||||||
if (!cancelled) {
|
void renderHighlightedCodeBlockHtml(draft.code, draft.language)
|
||||||
setHtml(nextHtml);
|
.then((nextHtml) => {
|
||||||
}
|
if (!cancelled) {
|
||||||
})
|
setHtml(nextHtml);
|
||||||
.catch(() => {
|
}
|
||||||
if (!cancelled) {
|
})
|
||||||
setHtml(null);
|
.catch(() => {
|
||||||
}
|
if (!cancelled) {
|
||||||
});
|
setHtml(null);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}, 100);
|
||||||
|
|
||||||
return () => {
|
return () => {
|
||||||
cancelled = true;
|
cancelled = true;
|
||||||
|
clearTimeout(timeoutId);
|
||||||
};
|
};
|
||||||
}, [draft.code, draft.language]);
|
}, [draft.code, draft.language]);
|
||||||
|
|
||||||
|
|||||||
+1
-8
@@ -75,14 +75,7 @@ export function normalizeScene(input: unknown): ScenePayload {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export function parseJsonBody<T = unknown>(text: string): T {
|
export function parseJsonBody<T = unknown>(text: string): T {
|
||||||
// Optimization: TextEncoder.encode creates a new Uint8Array and allocates memory for the entire
|
if (new TextEncoder().encode(text).byteLength > MAX_SCENE_BYTES) {
|
||||||
// string, which is slow for large JSON payloads. Buffer.byteLength counts bytes without allocation.
|
|
||||||
const byteLength =
|
|
||||||
typeof Buffer !== "undefined"
|
|
||||||
? Buffer.byteLength(text)
|
|
||||||
: new TextEncoder().encode(text).byteLength;
|
|
||||||
|
|
||||||
if (byteLength > MAX_SCENE_BYTES) {
|
|
||||||
throw new HttpError(413, "Payload too large");
|
throw new HttpError(413, "Payload too large");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user