Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 0f984d4dea | |||
| 0a1d70b605 | |||
| 40bf063490 |
@@ -1,4 +0,0 @@
|
||||
## 2025-06-03 - Avoid TextEncoder for string byte length
|
||||
|
||||
**Learning:** `new TextEncoder().encode(text).byteLength` allocates a `Uint8Array` for the entire string, which causes significant memory allocations and is ~100x slower for large JSON payloads in Bun/Node.
|
||||
**Action:** Use `Buffer.byteLength(text)` when available (with a fallback to `TextEncoder` for browser compatibility) to compute string byte lengths without memory allocation overhead.
|
||||
File diff suppressed because one or more lines are too long
+1
-8
@@ -75,14 +75,7 @@ export function normalizeScene(input: unknown): ScenePayload {
|
||||
}
|
||||
|
||||
export function parseJsonBody<T = unknown>(text: string): T {
|
||||
// Optimization: TextEncoder.encode creates a new Uint8Array and allocates memory for the entire
|
||||
// string, which is slow for large JSON payloads. Buffer.byteLength counts bytes without allocation.
|
||||
const byteLength =
|
||||
typeof Buffer !== "undefined"
|
||||
? Buffer.byteLength(text)
|
||||
: new TextEncoder().encode(text).byteLength;
|
||||
|
||||
if (byteLength > MAX_SCENE_BYTES) {
|
||||
if (new TextEncoder().encode(text).byteLength > MAX_SCENE_BYTES) {
|
||||
throw new HttpError(413, "Payload too large");
|
||||
}
|
||||
|
||||
|
||||
@@ -12,6 +12,7 @@ export function createServer(options: CreateServerOptions = {}) {
|
||||
return {
|
||||
port: Number(process.env.PORT ?? "3000"),
|
||||
hostname: process.env.HOST ?? "localhost",
|
||||
idleTimeout: 120,
|
||||
routes: {
|
||||
"/": (request: Request) => {
|
||||
const drawing = drawingStore.ensureInitialDrawing();
|
||||
|
||||
Reference in New Issue
Block a user