Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 462b754d95 |
@@ -1,4 +0,0 @@
|
|||||||
## 2025-06-03 - Avoid TextEncoder for string byte length
|
|
||||||
|
|
||||||
**Learning:** `new TextEncoder().encode(text).byteLength` allocates a `Uint8Array` for the entire string, which causes significant memory allocations and is ~100x slower for large JSON payloads in Bun/Node.
|
|
||||||
**Action:** Use `Buffer.byteLength(text)` when available (with a fallback to `TextEncoder` for browser compatibility) to compute string byte lengths without memory allocation overhead.
|
|
||||||
@@ -0,0 +1,5 @@
|
|||||||
|
## 2025-06-07 - [Added Security Headers via Caddy]
|
||||||
|
|
||||||
|
**Vulnerability:** Missing HTTP security headers (CSP, X-Frame-Options, X-Content-Type-Options, Referrer-Policy).
|
||||||
|
**Learning:** The application does not apply security headers in the Bun application server but instead relies on the Caddy reverse proxy to inject them in the `Caddyfile`.
|
||||||
|
**Prevention:** Always configure security headers at the reverse proxy level (`Caddyfile`) instead of within the backend API routing code to ensure all routes, including static files, are properly protected.
|
||||||
@@ -6,6 +6,12 @@
|
|||||||
:80 {
|
:80 {
|
||||||
encode zstd gzip
|
encode zstd gzip
|
||||||
|
|
||||||
|
header {
|
||||||
|
X-Frame-Options "SAMEORIGIN"
|
||||||
|
X-Content-Type-Options "nosniff"
|
||||||
|
Referrer-Policy "strict-origin-when-cross-origin"
|
||||||
|
}
|
||||||
|
|
||||||
handle /mcp {
|
handle /mcp {
|
||||||
reverse_proxy 127.0.0.1:3001
|
reverse_proxy 127.0.0.1:3001
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-8
@@ -75,14 +75,7 @@ export function normalizeScene(input: unknown): ScenePayload {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export function parseJsonBody<T = unknown>(text: string): T {
|
export function parseJsonBody<T = unknown>(text: string): T {
|
||||||
// Optimization: TextEncoder.encode creates a new Uint8Array and allocates memory for the entire
|
if (new TextEncoder().encode(text).byteLength > MAX_SCENE_BYTES) {
|
||||||
// string, which is slow for large JSON payloads. Buffer.byteLength counts bytes without allocation.
|
|
||||||
const byteLength =
|
|
||||||
typeof Buffer !== "undefined"
|
|
||||||
? Buffer.byteLength(text)
|
|
||||||
: new TextEncoder().encode(text).byteLength;
|
|
||||||
|
|
||||||
if (byteLength > MAX_SCENE_BYTES) {
|
|
||||||
throw new HttpError(413, "Payload too large");
|
throw new HttpError(413, "Payload too large");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user