Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| ad1242ad67 |
+3
-3
@@ -1,4 +1,4 @@
|
|||||||
## 2024-06-07 - Memoize callbacks passed to Excalidraw
|
## 2025-06-03 - Avoid TextEncoder for string byte length
|
||||||
|
|
||||||
**Learning:** Due to the exceptionally high rendering cost of the `@excalidraw/excalidraw` canvas, always ensure all callbacks passed to it (e.g., `onExcalidrawAPI`) are strictly memoized using `useCallback`. Passing inline functions as props breaks prop stability for `React.memo` and causes severe UI input lag caused by full canvas re-renders when parent states change.
|
**Learning:** `new TextEncoder().encode(text).byteLength` allocates a `Uint8Array` for the entire string, which causes significant memory allocations and is ~100x slower for large JSON payloads in Bun/Node.
|
||||||
**Action:** When working with `<Excalidraw>` or its wrapper components like `<EditorCanvas>`, always extract inline callback functions (like `onExcalidrawAPI={(api) => { ... }}`) into `useCallback` hooks before passing them down.
|
**Action:** Use `Buffer.byteLength(text)` when available (with a fallback to `TextEncoder` for browser compatibility) to compute string byte lengths without memory allocation overhead.
|
||||||
|
|||||||
+3
-8
@@ -307,13 +307,6 @@ function PrivateApp() {
|
|||||||
[],
|
[],
|
||||||
);
|
);
|
||||||
|
|
||||||
// ⚡ Bolt: Memoize the Excalidraw API callback to prevent EditorCanvas from re-rendering
|
|
||||||
// Excalidraw has exceptionally high rendering cost, so we must maintain prop stability
|
|
||||||
// for EditorCanvas's React.memo to avoid severe UI input lag on any parent state change.
|
|
||||||
const handleExcalidrawAPI = useCallback((api: ExcalidrawImperativeAPI) => {
|
|
||||||
excalidrawApiRef.current = api;
|
|
||||||
}, []);
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="app-shell" ref={appShellRef}>
|
<div className="app-shell" ref={appShellRef}>
|
||||||
{toastMessage && (
|
{toastMessage && (
|
||||||
@@ -339,7 +332,9 @@ function PrivateApp() {
|
|||||||
onSceneChange={handleSceneChange}
|
onSceneChange={handleSceneChange}
|
||||||
onSelectionStateChange={handleCodeBlockSelectionChange}
|
onSelectionStateChange={handleCodeBlockSelectionChange}
|
||||||
onEditorActivity={scheduleThemeTokenSync}
|
onEditorActivity={scheduleThemeTokenSync}
|
||||||
onExcalidrawAPI={handleExcalidrawAPI}
|
onExcalidrawAPI={(api) => {
|
||||||
|
excalidrawApiRef.current = api;
|
||||||
|
}}
|
||||||
renderEmbeddable={renderCodeBlockEmbeddable}
|
renderEmbeddable={renderCodeBlockEmbeddable}
|
||||||
/>
|
/>
|
||||||
<CodeBlockSidebar
|
<CodeBlockSidebar
|
||||||
|
|||||||
+8
-1
@@ -75,7 +75,14 @@ export function normalizeScene(input: unknown): ScenePayload {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export function parseJsonBody<T = unknown>(text: string): T {
|
export function parseJsonBody<T = unknown>(text: string): T {
|
||||||
if (new TextEncoder().encode(text).byteLength > MAX_SCENE_BYTES) {
|
// Optimization: TextEncoder.encode creates a new Uint8Array and allocates memory for the entire
|
||||||
|
// string, which is slow for large JSON payloads. Buffer.byteLength counts bytes without allocation.
|
||||||
|
const byteLength =
|
||||||
|
typeof Buffer !== "undefined"
|
||||||
|
? Buffer.byteLength(text)
|
||||||
|
: new TextEncoder().encode(text).byteLength;
|
||||||
|
|
||||||
|
if (byteLength > MAX_SCENE_BYTES) {
|
||||||
throw new HttpError(413, "Payload too large");
|
throw new HttpError(413, "Payload too large");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user